]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
powerpc/perf: Fix ABIv2 kernel backtraces
authorAnton Blanchard <anton@samba.org>
Tue, 26 Aug 2014 02:44:15 +0000 (12:44 +1000)
committerJiri Slaby <jslaby@suse.cz>
Thu, 9 Apr 2015 12:13:35 +0000 (14:13 +0200)
commitb0f017f75dee6ee88baa55ead0c14dc797d5a4e1
treeba6bf6f213ab58c23778f6aec82f7ae8b81c9036
parent05436bbe5e062cf91c79143eb01fd5006b653cbb
powerpc/perf: Fix ABIv2 kernel backtraces

commit 85101af13bb854a6572fa540df7c7201958624b9 upstream.

ABIv2 kernels are failing to backtrace through the kernel. An example:

39.30%  readseek2_proce  [kernel.kallsyms]    [k] find_get_entry
            |
            --- find_get_entry
               __GI___libc_read

The problem is in valid_next_sp() where we check that the new stack
pointer is at least STACK_FRAME_OVERHEAD below the previous one.

ABIv1 has a minimum stack frame size of 112 bytes consisting of 48 bytes
and 64 bytes of parameter save area. ABIv2 changes that to 32 bytes
with no paramter save area.

STACK_FRAME_OVERHEAD is in theory the minimum stack frame size,
but we over 240 uses of it, some of which assume that it includes
space for the parameter area.

We need to work through all our stack defines and rationalise them
but let's fix perf now by creating STACK_FRAME_MIN_SIZE and using
in valid_next_sp(). This fixes the issue:

30.64%  readseek2_proce  [kernel.kallsyms]    [k] find_get_entry
            |
            --- find_get_entry
               pagecache_get_page
               generic_file_read_iter
               new_sync_read
               vfs_read
               sys_read
               syscall_exit
               __GI___libc_read

Cc: stable@vger.kernel.org # 3.16+
Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
arch/powerpc/include/asm/ptrace.h
arch/powerpc/perf/callchain.c