]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fs: lockd: avoid possible wrong NULL parameter
authorSu Hui <suhui@nfschina.com>
Fri, 4 Aug 2023 01:26:57 +0000 (09:26 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2023 10:22:43 +0000 (12:22 +0200)
commitb0f127a7c63589b843a6f8d45ccd37abd4327e3a
treee6fab52f0ba442a0c3447f556cf3f4f21373cf02
parent8f994b830dd0cf1239c85d900ce5df2030d95e0c
fs: lockd: avoid possible wrong NULL parameter

[ Upstream commit de8d38cf44bac43e83bad28357ba84784c412752 ]

clang's static analysis warning: fs/lockd/mon.c: line 293, column 2:
Null pointer passed as 2nd argument to memory copy function.

Assuming 'hostname' is NULL and calling 'nsm_create_handle()', this will
pass NULL as 2nd argument to memory copy function 'memcpy()'. So return
NULL if 'hostname' is invalid.

Fixes: 77a3ef33e2de ("NSM: More clean up of nsm_get_handle()")
Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/lockd/mon.c