]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Silence complaints about leaks in PlanCacheComputeResultDesc.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 2 Aug 2025 23:44:10 +0000 (19:44 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 3 Aug 2025 01:59:46 +0000 (21:59 -0400)
commitb102c8c4733cf76ff0635dc440ee8dd11487ed95
tree5d4fab2ae6e17adda0e2c1dee696095955adcc17
parent7f6ededa764b287ba593a2bb7fd566df8053213e
Silence complaints about leaks in PlanCacheComputeResultDesc.

CompleteCachedPlan intentionally doesn't worry about small
leaks from PlanCacheComputeResultDesc.  However, Valgrind
knows nothing of engineering tradeoffs and complains anyway.
Silence it by doing things the hard way if USE_VALGRIND.

I don't really love this patch, because it makes the handling
of plansource->resultDesc different from the handling of query
dependencies and search_path just above, which likewise are willing
to accept small leaks into the cached plan's context.  However,
those cases aren't provoking Valgrind complaints.  (Perhaps in a
CLOBBER_CACHE_ALWAYS build, they would?)  For the moment, this
makes the src/pl/plpgsql tests leak-free according to Valgrind.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/285483.1746756246@sss.pgh.pa.us
src/backend/utils/cache/plancache.c