]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: dsa: bcm_sf2: Do not override speed settings
authorFlorian Fainelli <f.fainelli@gmail.com>
Tue, 21 Jul 2015 00:49:55 +0000 (17:49 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Oct 2015 11:51:39 +0000 (13:51 +0200)
commitb11c94db52901ca6b5167a2089f14e679cbe0cee
tree7dbdfd0fb52ec0aa842e3a73b5e854d81aa515fa
parent4c8f9d6cf799cf77d6e0a2ad0d26e066be630bf9
net: dsa: bcm_sf2: Do not override speed settings

[ Upstream d2eac98f7d1b950b762a7eca05a9ce0ea1d878d2 in net-next tree,
  will be pushed to Linus very soon. ]

The SF2 driver currently overrides speed settings for its port
configured using a fixed PHY, this is both unnecessary and incorrect,
because we keep feedback to the hardware parameters that we read from
the PHY device, which in the case of a fixed PHY cannot possibly change
speed.

This is a required change to allow the fixed PHY code to allow
registering a PHY with a link configured as DOWN by default and avoid
some sort of circular dependency where we require the link_update
callback to run to program the hardware, and we then utilize the fixed
PHY parameters to program the hardware with the same settings.

Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switch driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/dsa/bcm_sf2.c