]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-91447: Fix findtext to only give an empty string on None (GH-91486)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 1 Aug 2022 21:22:33 +0000 (14:22 -0700)
committerGitHub <noreply@github.com>
Mon, 1 Aug 2022 21:22:33 +0000 (14:22 -0700)
commitb12dba40ff00e0c7a47036401cdcfbe3845d9c2a
treeb051b3c07be814ab1710f5a3412f2e4172f2d027
parent7baca3c05e16d1faeb8c77f07706b84677d97a3d
gh-91447: Fix findtext to only give an empty string on None (GH-91486)

The API documentation for [findtext](https://docs.python.org/3/library/xml.etree.elementtree.htmlGH-xml.etree.ElementTree.Element.findtext) states that this function gives back an empty string on "no text content." With the previous implementation, this would give back a empty string even on text content values such as 0 or False. This patch attempts to resolve that by only giving back an empty string if the text attribute is set to `None`. Resolves GH-91447.

Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit a95e60db748ec6f2c19b5710c11f62e1e4d669f4)

Co-authored-by: Eugene Triguba <eugenetriguba@gmail.com>
Lib/test/test_xml_etree.py
Lib/xml/etree/ElementPath.py
Misc/NEWS.d/next/Library/2022-04-12-18-05-40.gh-issue-91447.N_Fs4H.rst [new file with mode: 0644]