]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
io_uring: fix filename leak in __io_openat_prep()
authorPrithvi Tambewagh <activprithvi@gmail.com>
Thu, 25 Dec 2025 07:28:29 +0000 (12:58 +0530)
committerJens Axboe <axboe@kernel.dk>
Thu, 25 Dec 2025 14:58:33 +0000 (07:58 -0700)
commitb14fad555302a2104948feaff70503b64c80ac01
tree9d523e029a74aa8513551b0f4f1931eab64cf139
parent114ea9bbaf7681c4d363e13b7916e6fef6a4963a
io_uring: fix filename leak in __io_openat_prep()

 __io_openat_prep() allocates a struct filename using getname(). However,
for the condition of the file being installed in the fixed file table as
well as having O_CLOEXEC flag set, the function returns early. At that
point, the request doesn't have REQ_F_NEED_CLEANUP flag set. Due to this,
the memory for the newly allocated struct filename is not cleaned up,
causing a memory leak.

Fix this by setting the REQ_F_NEED_CLEANUP for the request just after the
successful getname() call, so that when the request is torn down, the
filename will be cleaned up, along with other resources needing cleanup.

Reported-by: syzbot+00e61c43eb5e4740438f@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=00e61c43eb5e4740438f
Tested-by: syzbot+00e61c43eb5e4740438f@syzkaller.appspotmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Prithvi Tambewagh <activprithvi@gmail.com>
Fixes: b9445598d8c6 ("io_uring: openat directly into fixed fd table")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/openclose.c