]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/bochs: Drop manual put on probe error path
authorMyeonghun Pak <mhun512@gmail.com>
Fri, 24 Apr 2026 12:34:28 +0000 (21:34 +0900)
committerThomas Zimmermann <tzimmermann@suse.de>
Thu, 7 May 2026 08:51:18 +0000 (10:51 +0200)
commitb15838b03cd0c6cf35651cfde62d17f14bb1d566
tree4e9428f4ea3c460120417bb8c036e6be7a4908bf
parent26f6654a9a60eb4d241f42a0ec85412e8821480b
drm/bochs: Drop manual put on probe error path

bochs_pci_probe() allocates the DRM device with devm_drm_dev_alloc(),
which registers a devres action to drop the initial DRM device reference
on driver detach or probe failure.

The error path currently calls drm_dev_put() manually. If probe then
returns an error, devres will run the registered release action and put
the same device again, after the first put may already have released it.

Return the probe error directly and let devres own the final put.

Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
Fixes: 04826f588682 ("drm/bochs: Allocate DRM device in struct bochs_device")
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patch.msgid.link/20260424123506.32275-1-mhun512@gmail.com
drivers/gpu/drm/tiny/bochs.c