]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Remove two-stage construction of commands in nwfilter
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 25 Mar 2014 16:10:56 +0000 (16:10 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Fri, 25 Apr 2014 14:44:09 +0000 (15:44 +0100)
commitb1c1df05bf1be34eb092bd48b3a01632cea0a65c
tree9fb4f4edbd095ab2de620c7b9213089547669947
parent3f74b2eb2cf995fe5a4dbef83004d5fef96e7417
Remove two-stage construction of commands in nwfilter

The nwfilter ebiptables driver will build up commands to run in
two phases. The first phase contains all of the command, except
for the '-A' part. Instead it has a '%c' placeholder, along with
a '%s' placeholder for a position arg. The second phase than
substitutes these placeholders. The only values ever used for
these substitutions though is '-A' and '', so it is entirely
pointless. Remove the second phase entirely, since it will make
it harder to convert to the new firewall APIs

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/nwfilter/nwfilter_ebiptables_driver.c