]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rust: sync: remove unneeded `#[allow(clippy::non_send_fields_in_send_ty)]`
authorMiguel Ojeda <ojeda@kernel.org>
Fri, 7 Mar 2025 22:49:17 +0000 (23:49 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 12:01:41 +0000 (13:01 +0100)
commitb212da6fdf04970cadae34a90eafabc3fd419385
tree097f90411a361e3b57cda35dd71b2869eb066eba
parentd09e7c93df7ca2037f3f24fc364e5b9cc39a689b
rust: sync: remove unneeded `#[allow(clippy::non_send_fields_in_send_ty)]`

commit 5e7c9b84ad08cc7a41b2ddbbbaccb60057da3860 upstream.

Rust 1.58.0 (before Rust was merged into the kernel) made Clippy's
`non_send_fields_in_send_ty` lint part of the `suspicious` lint group for
a brief window of time [1] until the minor version 1.58.1 got released
a week after, where the lint was moved back to `nursery`.

By that time, we had already upgraded to that Rust version, and thus we
had `allow`ed the lint here for `CondVar`.

Nowadays, Clippy's `non_send_fields_in_send_ty` would still trigger here
if it were enabled.

Moreover, if enabled, `Lock<T, B>` and `Task` would also require an
`allow`. Therefore, it does not seem like someone is actually enabling it
(in, e.g., a custom flags build).

Finally, the lint does not appear to have had major improvements since
then [2].

Thus remove the `allow` since it is unneeded.

Link: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1581-2022-01-20
Link: https://github.com/rust-lang/rust-clippy/issues/8045
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Trevor Gross <tmgross@umich.edu>
Tested-by: Gary Guo <gary@garyguo.net>
Reviewed-by: Gary Guo <gary@garyguo.net>
Link: https://lore.kernel.org/r/20240904204347.168520-11-ojeda@kernel.org
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
rust/kernel/sync/condvar.rs