]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/handshake: restore destructor on submit failure
authorcaoping <caoping@cmss.chinamobile.com>
Thu, 4 Dec 2025 09:10:58 +0000 (01:10 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Jan 2026 11:57:23 +0000 (12:57 +0100)
commitb225325be7b247c7268e65eea6090db1fc786d1f
tree4d0725aa79dd76a344157d2b0a3595cf9780847f
parent7a93edb23bcf07a3aaf8b598edfc2faa8fbcc0b6
net/handshake: restore destructor on submit failure

commit 6af2a01d65f89e73c1cbb9267f8880d83a88cee4 upstream.

handshake_req_submit() replaces sk->sk_destruct but never restores it when
submission fails before the request is hashed. handshake_sk_destruct() then
returns early and the original destructor never runs, leaking the socket.
Restore sk_destruct on the error path.

Fixes: 3b3009ea8abb ("net/handshake: Create a NETLINK service for handling handshake requests")
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: caoping <caoping@cmss.chinamobile.com>
Link: https://patch.msgid.link/20251204091058.1545151-1-caoping@cmss.chinamobile.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/handshake/request.c