]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commit
oeqa/qemurunner: do not use Popen.poll() when terminating runqemu with a signal
authorAlexander Kanavin <alex.kanavin@gmail.com>
Mon, 30 Jan 2023 22:11:25 +0000 (23:11 +0100)
committerSteve Sakoman <steve@sakoman.com>
Sat, 11 Feb 2023 14:03:33 +0000 (04:03 -1000)
commitb228cdf9d4b00411d772a7b605566d33a3a1b82b
tree1fc8f3124b93cd995d1dcef2b35d66c87978073e
parent625ed0898518bcd699cb16f6e1cc0813eca0c48f
oeqa/qemurunner: do not use Popen.poll() when terminating runqemu with a signal

This does not actually guarantee that the child runqemu process has completely exited:
poll() may return prematurely while the SIGTERM handler in runqemu is still running.
This thwarts the rest of the processing, and may terminate the handler before
it completes.

Use Popen.communicate() instead: this is what python documentation recommends as well:
https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit cd3e55606c427287f37585c5d7cde936471e52f4)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/lib/oeqa/utils/qemurunner.py