]> git.ipfire.org Git - thirdparty/linux.git/commit
vfio: Fix unbalanced vfio_df_close call in no-iommu mode
authorJacob Pan <jacob.pan@linux.microsoft.com>
Wed, 18 Jun 2025 23:46:17 +0000 (16:46 -0700)
committerAlex Williamson <alex.williamson@redhat.com>
Fri, 11 Jul 2025 20:43:37 +0000 (14:43 -0600)
commitb25e271b377999191b12f0afbe1861edcf57e3fe
treecf36e7a9fe0e39a39f6511dd3592af4bcc328ba9
parentd7b8f8e20813f0179d8ef519541a3527e7661d3a
vfio: Fix unbalanced vfio_df_close call in no-iommu mode

For devices with no-iommu enabled in IOMMUFD VFIO compat mode, the group open
path skips vfio_df_open(), leaving open_count at 0. This causes a warning in
vfio_assert_device_open(device) when vfio_df_close() is called during group
close.

The correct behavior is to skip only the IOMMUFD bind in the device open path
for no-iommu devices. Commit 6086efe73498 omitted vfio_df_open(), which was
too broad. This patch restores the previous behavior, ensuring
the vfio_df_open is called in the group open path.

Fixes: 6086efe73498 ("vfio-iommufd: Move noiommu compat validation out of vfio_iommufd_bind()")
Suggested-by: Alex Williamson <alex.williamson@redhat.com>
Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Jacob Pan <jacob.pan@linux.microsoft.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20250618234618.1910456-1-jacob.pan@linux.microsoft.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/group.c
drivers/vfio/iommufd.c