]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr()
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Wed, 17 Sep 2014 15:58:27 +0000 (17:58 +0200)
committerJiri Slaby <jslaby@suse.cz>
Fri, 31 Oct 2014 14:11:21 +0000 (15:11 +0100)
commitb25f6852b313d61224e2e693ad11a180ff055cb6
treed09fba3f22ef2bd08e1723b3d855af6d3f82dc71
parent1866cdf3c46ba5f02bb5162006e1928af77c5ebb
PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr()

commit 56fab6e189441d714a2bfc8a64f3df9c0749dff7 upstream.

Geert Uytterhoeven reported a warning when building pci-mvebu:

  drivers/pci/host/pci-mvebu.c: In function 'mvebu_get_tgt_attr':
  drivers/pci/host/pci-mvebu.c:887:39: warning: 'rtype' may be used uninitialized in this function [-Wmaybe-uninitialized]
     if (slot == PCI_SLOT(devfn) && type == rtype) {
 ^

And indeed, the code of mvebu_get_tgt_attr() may lead to the usage of rtype
when being uninitialized, even though it would only happen if we had
entries other than I/O space and 32 bits memory space.

This commit fixes that by simply skipping the current DT range being
considered, if it doesn't match the resource type we're looking for.

Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/pci/host/pci-mvebu.c