]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: ethernet: cortina: Drop half-assembled SKB
authorAndreas Haarmann-Thiemann <eitschman@nebelreich.de>
Tue, 5 May 2026 21:52:17 +0000 (23:52 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 7 May 2026 01:43:41 +0000 (18:43 -0700)
commitb266bacba796ff5c4dcd2ae2fc08aacf7ab39153
tree81d8b06d4509d00465b01170b2daaae6b22f173c
parent2b1f48cc0f31abd1115a8c4b74b6425aba46eae4
net: ethernet: cortina: Drop half-assembled SKB

In gmac_rx() (drivers/net/ethernet/cortina/gemini.c), when
gmac_get_queue_page() returns NULL for the second page of a multi-page
fragment, the driver logs an error and continues — but does not free the
partially assembled skb that was being assembled via napi_build_skb() /
napi_get_frags().

Free the in-progress partially assembled skb via napi_free_frags()
and increase the number of dropped frames appropriately
and assign the skb pointer NULL to make sure it is not lingering
around, matching the pattern already used elsewhere in the driver.

Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
Signed-off-by: Andreas Haarmann-Thiemann <eitschman@nebelreich.de>
Signed-off-by: Linus Walleij <linusw@kernel.org>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Link: https://patch.msgid.link/20260505-gemini-ethernet-fix-v2-1-997c31d06079@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cortina/gemini.c