]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mmc: tmio: fix SCC error handling to avoid false positive CRC error
authorTakeshi Saito <takeshi.saito.xv@renesas.com>
Wed, 15 May 2019 18:23:46 +0000 (20:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jun 2019 10:19:17 +0000 (12:19 +0200)
commitb27cbe569e993e2d804ff0cceae683bcf27f0314
treebeac244b58044b49161b61089cf6af3268ae7ae1
parent4a1ef8ab4aadc568a890a85a33ee15cf60d5cf2a
mmc: tmio: fix SCC error handling to avoid false positive CRC error

commit 51b72656bb39fdcb8f3174f4007bcc83ad1d275f upstream.

If an SCC error occurs during a read/write command execution, a false
positive CRC error message is output.

mmcblk0: response CRC error sending r/w cmd command, card status 0x900

check_scc_error() checks SCC_RVSREQ.RVSERR bit. RVSERR detects a
correction error in the next (up or down) delay tap position. However,
since the command is successful, only retuning needs to be executed.
This has been confirmed by HW engineers.

Thus, on SCC error, set retuning flag instead of setting an error code.

Fixes: b85fb0a1c8ae ("mmc: tmio: Fix SCC error detection")
Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
[wsa: updated comment and commit message, removed some braces]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mmc/host/tmio_mmc_core.c