]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
power: supply: bq24190_charger: fix reference leak
authorZhang Qilong <zhangqilong3@huawei.com>
Mon, 2 Nov 2020 14:33:21 +0000 (22:33 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Dec 2020 12:46:56 +0000 (13:46 +0100)
commitb2a2eea570d19ec0ec93dab18c78beb62d80fe78
tree95cbfef265e86efdc9179f2167f4672d8eb95720
parent0849d36184202130dd287389cd547030e167550e
power: supply: bq24190_charger: fix reference leak

[ Upstream commit b2f6cb78eaa1cad57dd3fe11d0458cd4fae9a584 ]

pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to call pm_runtime_put_noidle will result
in reference leak in callers(bq24190_sysfs_show,
bq24190_charger_get_property, bq24190_charger_set_property,
bq24190_battery_get_property, bq24190_battery_set_property),
so we should fix it.

Fixes: f385e6e2a1532 ("power: bq24190_charger: Use PM runtime autosuspend")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/power/supply/bq24190_charger.c