]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdb/dwarf: remove redundant read of dwo_name
authorSimon Marchi <simon.marchi@efficios.com>
Tue, 25 Mar 2025 20:32:19 +0000 (16:32 -0400)
committerSimon Marchi <simon.marchi@efficios.com>
Wed, 26 Mar 2025 14:09:29 +0000 (10:09 -0400)
commitb2eb2b00dc5573f607647bb163f19d9f1e2c6f3d
treebd1566ea3ff6df5a81f52da797d2315cdcff753c
parent6d1823dc899bb0df45a79c32ea4ef571c1414fcb
gdb/dwarf: remove redundant read of dwo_name

lookup_dwo_unit receives the name of the DWO unit to look up, as read
from the DW_AT_dwo_name attribute of the skeleton DIE.  But then, it
doesn't use it:

    /* Yeah, we look dwo_name up again, but it simplifies the code.  */
    dwo_name = dwarf2_dwo_name (comp_unit_die, cu);

Perhaps this comment made sense at some point, but with the code we have
today, I don't understand it.  It should be fine to use the name passed
as a parameter, which the caller also obtained by calling
dwarf2_dwo_name.

Change-Id: I84723e12726f77e4202d042428ee0eed9962ceb8
Approved-By: Tom Tromey <tom@tromey.com>
gdb/dwarf2/read.c