]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
hpsa: refine the pci enable/disable handling
authorTomas Henzl <thenzl@redhat.com>
Thu, 14 Aug 2014 14:12:39 +0000 (16:12 +0200)
committerJiri Slaby <jslaby@suse.cz>
Tue, 26 May 2015 12:33:43 +0000 (14:33 +0200)
commitb30e0283beda471289c36157828db98066599d3d
tree26a3dcce10a23b473140b96a5ec2ee028723c59c
parent4d16cfbf033dac0876ddecf1b2947d1d7d74620c
hpsa: refine the pci enable/disable handling

commit 132aa220b45d60e9b20def1e9d8be9422eed9616 upstream.

When a second(kdump) kernel starts and the hard reset method is used
the driver calls pci_disable_device without previously enabling it,
so the kernel shows a warning -
[   16.876248] WARNING: at drivers/pci/pci.c:1431 pci_disable_device+0x84/0x90()
[   16.882686] Device hpsa
disabling already-disabled device
...
This patch fixes it, in addition to this I tried to balance also some other pairs
of enable/disable device in the driver.
Unfortunately I wasn't able to verify the functionality for the case of a sw reset,
because of a lack of proper hw.

Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Reviewed-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/scsi/hpsa.c