]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: idmouse: fix an uninit-value in idmouse_open
authorDongliang Mu <mudongliangabcd@gmail.com>
Thu, 22 Sep 2022 13:48:44 +0000 (21:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:15:48 +0000 (13:15 +0200)
commitb3304a6df957cc89a0590cb505388d659bf3db4c
tree6281873450e3203c4ccd786be860487b9b1ceec5
parent7f214204d240634583a2ad9c7d6d79bfa54a8f9d
usb: idmouse: fix an uninit-value in idmouse_open

[ Upstream commit bce2b0539933e485d22d6f6f076c0fcd6f185c4c ]

In idmouse_create_image, if any ftip_command fails, it will
go to the reset label. However, this leads to the data in
bulk_in_buffer[HEADER..IMGSIZE] uninitialized. And the check
for valid image incurs an uninitialized dereference.

Fix this by moving the check before reset label since this
check only be valid if the data after bulk_in_buffer[HEADER]
has concrete data.

Note that this is found by KMSAN, so only kernel compilation
is tested.

Reported-by: syzbot+79832d33eb89fb3cd092@syzkaller.appspotmail.com
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Link: https://lore.kernel.org/r/20220922134847.1101921-1-dzm91@hust.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/misc/idmouse.c