]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
efi: pstore: Drop efivar lock when efi_pstore_open() returns with an error
authorThomas Huth <thuth@redhat.com>
Mon, 27 Apr 2026 15:56:30 +0000 (17:56 +0200)
committerArd Biesheuvel <ardb@kernel.org>
Tue, 28 Apr 2026 10:31:02 +0000 (12:31 +0200)
commitb336e40c62fbdc4b8a1f09a4ada31f4a90c69eb1
tree0eed302326605046d24e48f9c7923a0e8a6d66d8
parenta9e8765fd206388d5672db229784982bf559f097
efi: pstore: Drop efivar lock when efi_pstore_open() returns with an error

If kzalloc fails, the function returns -ENOMEM without calling
efivar_unlock(). Since open() returned  an error, the calling site
in pstore_get_backend_records() won't call the close() function, so
the lock is never released. Thus drop the lock in case of errors here.

Fixes: 859748255b434 ("efi: pstore: Omit efivars caching EFI varstore access layer")
Assisted-by: Claude:claude-opus-4-6
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
drivers/firmware/efi/efi-pstore.c