]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
backlight: lm3509_bl: Fix early returns in for_each_child_of_node()
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Mon, 24 Jun 2024 15:30:50 +0000 (17:30 +0200)
committerLee Jones <lee@kernel.org>
Wed, 26 Jun 2024 15:49:59 +0000 (16:49 +0100)
commitb337cc3ce47549528fc3ee0b8c7ebd33348a3126
tree828f328affb3a2bc78ab4134d3c9f0d42294974d
parentbfd3587760498227510acc1b18c4299c7922ffe3
backlight: lm3509_bl: Fix early returns in for_each_child_of_node()

The for_each_child_of_node() macro automatically decrements the child
refcount at the end of every iteration. On early exits, of_node_put()
must be used to manually decrement the refcount and avoid memory leaks.

The scoped version of the macro accounts for such early breaks, fixing
the early exits without the need for explicit calls to of_node_put().

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Closes: https://lore.kernel.org/r/202406172314.2vVgelaS-lkp@intel.com/
Fixes: b72755f5b577 ("backlight: Add new lm3509 backlight driver")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20240624-lm3509_bl_scoped-v1-1-ceba9df38f23@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/video/backlight/lm3509_bl.c