]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/sched: Add locking to drm_sched_entity_modify_sched
authorTvrtko Ursulin <tvrtko.ursulin@igalia.com>
Tue, 24 Sep 2024 10:19:07 +0000 (11:19 +0100)
committerChristian König <christian.koenig@amd.com>
Tue, 24 Sep 2024 13:48:04 +0000 (15:48 +0200)
commitb37918090b2e84133c6eb9a1e227b2b7092d219e
treefdfdf87de40d4fa8570772a113131a09b11be119
parent59e1c9d0682b86dafdc825707638cd87f3012dc6
drm/sched: Add locking to drm_sched_entity_modify_sched

Without the locking amdgpu currently can race between
amdgpu_ctx_set_entity_priority() (via drm_sched_entity_modify_sched()) and
drm_sched_job_arm(), leading to the latter accesing potentially
inconsitent entity->sched_list and entity->num_sched_list pair.

v2:
 * Improve commit message. (Philipp)

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Fixes: b37aced31eb0 ("drm/scheduler: implement a function to modify sched list")
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Luben Tuikov <ltuikov89@gmail.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: Philipp Stanner <pstanner@redhat.com>
Cc: <stable@vger.kernel.org> # v5.7+
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240924101914.2713-2-tursulin@igalia.com
Signed-off-by: Christian König <christian.koenig@amd.com>
drivers/gpu/drm/scheduler/sched_entity.c