]> git.ipfire.org Git - thirdparty/git.git/commit
t-reftable-pq: make merged_iter_pqueue_check() callable by reference
authorChandra Pratap <chandrapratap3519@gmail.com>
Thu, 1 Aug 2024 10:59:46 +0000 (16:29 +0530)
committerJunio C Hamano <gitster@pobox.com>
Thu, 1 Aug 2024 16:07:29 +0000 (09:07 -0700)
commitb37b71b129d9536aca7bb242ef9d0ab43243f613
treefdb6a0f0233f85a5a9fa66dacbbdef3c8abe0adc
parent2e707447e127c9da3736fe7fa4943640078cc97d
t-reftable-pq: make merged_iter_pqueue_check() callable by reference

merged_iter_pqueue_check() checks the validity of a priority queue
represented by a merged_iter_pqueue struct by asserting the
parent-child relation in the struct's heap. Explicity passing a
struct to this function means a copy of the entire struct is created,
which is inefficient.

Make the function accept a pointer to the struct instead. This is
safe to do since the function doesn't modify the struct in any way.
Make the function parameter 'const' to assert immutability.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/unit-tests/t-reftable-pq.c