]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fs: Fix uninitialized value issue in from_kuid and from_kgid
authorAlessandro Zanni <alessandro.zanni87@gmail.com>
Thu, 17 Oct 2024 12:05:51 +0000 (14:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Nov 2024 14:06:25 +0000 (15:06 +0100)
commitb3e612bd8f64ce62e731e95f635e06a2efe3c80c
tree4fb9c2e70ca4e7dbd4bf5a7d3f5c52053dc9a536
parent8004122bf90ea3406be4a9d01fe255ffd3f297e2
fs: Fix uninitialized value issue in from_kuid and from_kgid

[ Upstream commit 15f34347481648a567db67fb473c23befb796af5 ]

ocfs2_setattr() uses attr->ia_mode, attr->ia_uid and attr->ia_gid in
a trace point even though ATTR_MODE, ATTR_UID and ATTR_GID aren't set.

Initialize all fields of newattrs to avoid uninitialized variables, by
checking if ATTR_MODE, ATTR_UID, ATTR_GID are initialized, otherwise 0.

Reported-by: syzbot+6c55f725d1bdc8c52058@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=6c55f725d1bdc8c52058
Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
Link: https://lore.kernel.org/r/20241017120553.55331-1-alessandro.zanni87@gmail.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/ocfs2/file.c