]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rtc: pcf85363: fix wrong mask/val parameters in regmap_update_bits call
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Fri, 13 Oct 2023 14:34:21 +0000 (16:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:08:27 +0000 (11:08 +0100)
commitb3eaa0d43c747406516176d89e6b2924e5e5de8d
tree5a804ca95c859e889ef39471826ac4c6167924bc
parent20bd0198bebdd706bd4614b3933ef70d7c19618f
rtc: pcf85363: fix wrong mask/val parameters in regmap_update_bits call

[ Upstream commit 2be36c09b6b07306be33519e1aa70d2e2a2161bb ]

The current implementation passes PIN_IO_INTA_OUT (2) as a mask and
PIN_IO_INTAPM (GENMASK(1, 0)) as a value.
Swap the variables to assign mask and value the right way.

This error was first introduced with the alarm support. For better or
worse it worked as expected because 0x02 was applied as a mask to 0x03,
resulting 0x02 anyway. This will of course not work for any other value.

Fixes: e5aac267a10a ("rtc: pcf85363: add alarm support")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://lore.kernel.org/r/20231013-topic-pcf85363_regmap_update_bits-v1-1-c454f016f71f@gmail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-pcf85363.c