]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: rose: fix invalid array index in rose_kill_by_device()
authorPwnverse <stanksal@purdue.edu>
Mon, 22 Dec 2025 21:22:27 +0000 (21:22 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:35 +0000 (10:14 +0100)
commitb409ba9e1e63ccf3ab4cc061e33c1f804183543e
tree93a6ea475e2128fead5f0c0c157aff01f7b0d800
parentee4183501ea556dca31f5ffd8690aa9fd25b609f
net: rose: fix invalid array index in rose_kill_by_device()

[ Upstream commit 6595beb40fb0ec47223d3f6058ee40354694c8e4 ]

rose_kill_by_device() collects sockets into a local array[] and then
iterates over them to disconnect sockets bound to a device being brought
down.

The loop mistakenly indexes array[cnt] instead of array[i]. For cnt <
ARRAY_SIZE(array), this reads an uninitialized entry; for cnt ==
ARRAY_SIZE(array), it is an out-of-bounds read. Either case can lead to
an invalid socket pointer dereference and also leaks references taken
via sock_hold().

Fix the index to use i.

Fixes: 64b8bc7d5f143 ("net/rose: fix races in rose_kill_by_device()")
Co-developed-by: Fatma Alwasmi <falwasmi@purdue.edu>
Signed-off-by: Fatma Alwasmi <falwasmi@purdue.edu>
Signed-off-by: Pwnverse <stanksal@purdue.edu>
Link: https://patch.msgid.link/20251222212227.4116041-1-ritviktanksalkar@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/rose/af_rose.c