]> git.ipfire.org Git - thirdparty/linux.git/commit
selftests/bpf: Add test for struct_ops __ref argument in any position
authorVarun R Mallya <varunrmallya@gmail.com>
Sat, 21 Mar 2026 21:40:38 +0000 (03:10 +0530)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 24 Mar 2026 15:51:23 +0000 (08:51 -0700)
commitb43d574c00324f26732260b378fb473e024e9a21
tree15f310e32b08a2e227c1109e21de02fdf08d1c2f
parent25e3e1f1096089a64901ae1faa7b7b13446653db
selftests/bpf: Add test for struct_ops __ref argument in any position

Add a selftest to verify that the verifier correctly identifies refcounted
arguments in struct_ops programs, even when they are not the first
argument. This ensures that the restriction on tail calls for programs
with __ref arguments is properly enforced regardless of which argument
they appear in.

This test verifies the fix for check_struct_ops_btf_id() proposed by
Keisuke Nishimura [0], which corrected a bug where only the first
argument was checked for the refcounted flag.
The test includes:
- An update to bpf_testmod to add 'test_refcounted_multi', an operator with
  three arguments where the third is tagged with "__ref".
- A BPF program 'test_refcounted_multi' that attempts a tail call.
- A test runner that asserts the verifier rejects the program with
  "program with __ref argument cannot tail call".

[0]: https://lore.kernel.org/bpf/20260320130219.63711-1-keisuke.nishimura@inria.fr/

Signed-off-by: Varun R Mallya <varunrmallya@gmail.com>
Link: https://lore.kernel.org/r/20260321214038.80479-1-varunrmallya@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/prog_tests/test_struct_ops_multi_args.c [new file with mode: 0644]
tools/testing/selftests/bpf/progs/struct_ops_multi_args.c [new file with mode: 0644]
tools/testing/selftests/bpf/test_kmods/bpf_testmod.c
tools/testing/selftests/bpf/test_kmods/bpf_testmod.h