]> git.ipfire.org Git - thirdparty/systemd.git/commit
Revert NFTSet feature
authorYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 14 Jun 2022 06:06:27 +0000 (15:06 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Wed, 22 Jun 2022 13:23:58 +0000 (22:23 +0900)
commitb48ed70c79c6482e1f39b77d16e62043ff5042a5
tree58245c4075beb60a8558020b647dc67134beb68e
parent127b26f3d8b589907ed75a34d34ab330995778f9
Revert NFTSet feature

This reverts PR #22587 and its follow-up commit. More specifically,
2299b1cae32c1fb8911da0ce26efced68032f4f8 (partially),
e176f855278d5098d3fecc5aa24ba702147d42e0,
ceb46a31a01b3d3d1d6095d857e29ea214a2776b, and
51bb9076ab8c050bebb64db5035852385accda35.

The PR was merged without final approval, and has several issues:
- OSS fuzz reported issues in the conf parser,
- It calls synchrnous netlink call, it should not be especially in PID1,
- The importance of NFTSet for CGroup and DynamicUser may be
  questionable, at least, there was no justification PID1 should support
  it.
- For networkd, it should be implemented with Request object,
- There is no test for the feature.

Fixes #23711.
Fixes #23717.
Fixes #23719.
Fixes #23720.
Fixes #23721.
Fixes #23759.
33 files changed:
man/org.freedesktop.systemd1.xml
man/systemd.exec.xml
man/systemd.network.xml
man/systemd.resource-control.xml
src/basic/parse-util.c
src/basic/parse-util.h
src/core/cgroup.c
src/core/cgroup.h
src/core/dbus-cgroup.c
src/core/dbus-execute.c
src/core/execute.c
src/core/execute.h
src/core/load-fragment-gperf.gperf.in
src/core/load-fragment.c
src/core/load-fragment.h
src/core/service.c
src/network/networkd-address.c
src/network/networkd-address.h
src/network/networkd-network-gperf.gperf
src/network/networkd-network.c
src/network/networkd-network.h
src/shared/bus-unit-util.c
src/shared/firewall-util-nft.c
src/shared/firewall-util.h
src/test/meson.build
src/test/test-nft-set.c [deleted file]
test/fuzz/fuzz-network-parser/directives
test/fuzz/fuzz-unit-file/directives.mount
test/fuzz/fuzz-unit-file/directives.scope
test/fuzz/fuzz-unit-file/directives.service
test/fuzz/fuzz-unit-file/directives.slice
test/fuzz/fuzz-unit-file/directives.socket
test/fuzz/fuzz-unit-file/directives.swap