]> git.ipfire.org Git - thirdparty/linux.git/commit
usb: phy: isp1301: fix non-OF device reference imbalance
authorJohan Hovold <johan@kernel.org>
Thu, 18 Dec 2025 15:35:16 +0000 (16:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Dec 2025 14:48:46 +0000 (15:48 +0100)
commitb4b64fda4d30a83a7f00e92a0c8a1d47699609f3
treeef570dec49eddffdb2261869c03c1136ee1a5080
parent782be79e4551550d7a82b1957fc0f7347e6d461f
usb: phy: isp1301: fix non-OF device reference imbalance

A recent change fixing a device reference leak in a UDC driver
introduced a potential use-after-free in the non-OF case as the
isp1301_get_client() helper only increases the reference count for the
returned I2C device in the OF case.

Increment the reference count also for non-OF so that the caller can
decrement it unconditionally.

Note that this is inherently racy just as using the returned I2C device
is since nothing is preventing the PHY driver from being unbound while
in use.

Fixes: c84117912bdd ("USB: lpc32xx_udc: Fix error handling in probe")
Cc: stable@vger.kernel.org
Cc: Ma Ke <make24@iscas.ac.cn>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Link: https://patch.msgid.link/20251218153519.19453-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/phy/phy-isp1301.c