]> git.ipfire.org Git - thirdparty/linux.git/commit
bpf: Disable file_alloc_security hook
authorAmery Hung <ameryhung@gmail.com>
Wed, 26 Nov 2025 20:29:26 +0000 (12:29 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 28 Nov 2025 23:18:28 +0000 (15:18 -0800)
commitb4bf1d23dc1da236c92a9d9be68cc63358d1f750
treeaa7657f5b2f59e28de8837e79a422b1fa1440e15
parent19f4091bf2679759da877eb23a37863dc4368441
bpf: Disable file_alloc_security hook

A use-after-free bug may be triggered by calling bpf_inode_storage_get()
in a BPF LSM program hooked to file_alloc_security. Disable the hook to
prevent this from happening.

The cause of the bug is shown in the trace below. In alloc_file(), a
file struct is first allocated through kmem_cache_alloc(). Then,
file_alloc_security hook is invoked. Since the zero initialization or
assignment of f->f_inode happen after this LSM hook, a BPF program may
get a dangeld inode pointer by walking the file struct.

  alloc_file()
  -> alloc_empty_file()
     -> f = kmem_cache_alloc()
     -> init_file()
        -> security_file_alloc() // f->f_inode not init-ed yet!
     -> f->f_inode = NULL;
  -> file_init_path()
     -> f->f_inode = path->dentry->d_inode

Reported-by: Kaiyan Mei <M202472210@hust.edu.cn>
Reported-by: Yinhao Hu <dddddd@hust.edu.cn>
Reported-by: Dongliang Mu <dzm91@hust.edu.cn>
Closes: https://lore.kernel.org/bpf/1d2d1968.47cd3.19ab9528e94.Coremail.kaiyanm@hust.edu.cn/
Signed-off-by: Amery Hung <ameryhung@gmail.com>
Link: https://lore.kernel.org/r/20251126202927.2584874-1-ameryhung@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/bpf_lsm.c