]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
hwrng: omap - Fix assumption that runtime_get_sync will always succeed
authorNishanth Menon <nm@ti.com>
Fri, 24 Jun 2016 16:50:39 +0000 (11:50 -0500)
committerJiri Slaby <jslaby@suse.cz>
Fri, 7 Oct 2016 08:06:51 +0000 (10:06 +0200)
commitb4c3486e71beef32a2e67451a0e916e894401afe
tree67bb7f0d7825fe75bbfe8d2decb0e98f65bbc5aa
parent6fd1d5bfa438a89147b968ea7c56350b4940df79
hwrng: omap - Fix assumption that runtime_get_sync will always succeed

commit 61dc0a446e5d08f2de8a24b45f69a1e302bb1b1b upstream.

pm_runtime_get_sync does return a error value that must be checked for
error conditions, else, due to various reasons, the device maynot be
enabled and the system will crash due to lack of clock to the hardware
module.

Before:
12.562784] [00000000] *pgd=fe193835
12.562792] Internal error: : 1406 [#1] SMP ARM
[...]
12.562864] CPU: 1 PID: 241 Comm: modprobe Not tainted 4.7.0-rc4-next-20160624 #2
12.562867] Hardware name: Generic DRA74X (Flattened Device Tree)
12.562872] task: ed51f140 ti: ed44c000 task.ti: ed44c000
12.562886] PC is at omap4_rng_init+0x20/0x84 [omap_rng]
12.562899] LR is at set_current_rng+0xc0/0x154 [rng_core]
[...]

After the proper checks:
[   94.366705] omap_rng 48090000.rng: _od_fail_runtime_resume: FIXME:
missing hwmod/omap_dev info
[   94.375767] omap_rng 48090000.rng: Failed to runtime_get device -19
[   94.382351] omap_rng 48090000.rng: initialization failed.

Fixes: 665d92fa85b5 ("hwrng: OMAP: convert to use runtime PM")
Cc: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/char/hw_random/omap-rng.c