]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
spi: tegra210-quad: Fix timeout handling
authorVishwaroop A <va@nvidia.com>
Tue, 28 Oct 2025 15:57:01 +0000 (15:57 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 4 Nov 2025 16:48:53 +0000 (16:48 +0000)
commitb4e002d8a7cee3b1d70efad0e222567f92a73000
tree2dccdd6b65183a1a24f743f16c00d6771faac278
parent6146a0f1dfae5d37442a9ddcba012add260bceb0
spi: tegra210-quad: Fix timeout handling

When the CPU that the QSPI interrupt handler runs on (typically CPU 0)
is excessively busy, it can lead to rare cases of the IRQ thread not
running before the transfer timeout is reached.

While handling the timeouts, any pending transfers are cleaned up and
the message that they correspond to is marked as failed, which leaves
the curr_xfer field pointing at stale memory.

To avoid this, clear curr_xfer to NULL upon timeout and check for this
condition when the IRQ thread is finally run.

While at it, also make sure to clear interrupts on failure so that new
interrupts can be run.

A better, more involved, fix would move the interrupt clearing into a
hard IRQ handler. Ideally we would also want to signal that the IRQ
thread no longer needs to be run after the timeout is hit to avoid the
extra check for a valid transfer.

Fixes: 921fc1838fb0 ("spi: tegra210-quad: Add support for Tegra210 QSPI controller")
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Vishwaroop A <va@nvidia.com>
Link: https://patch.msgid.link/20251028155703.4151791-2-va@nvidia.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra210-quad.c