]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix incorrect comment in JsonTablePlanJoinNextRow()
authorAmit Langote <amitlan@postgresql.org>
Thu, 16 Apr 2026 04:45:33 +0000 (13:45 +0900)
committerAmit Langote <amitlan@postgresql.org>
Thu, 16 Apr 2026 04:45:33 +0000 (13:45 +0900)
commitb5062a4e57fcdd51949a046314ec90731bdbf92c
tree9930cab1175dad77d0be91cc9825a96872cd97f7
parentee550254a29a4ccd3852f14b1806b8ffe26b7454
Fix incorrect comment in JsonTablePlanJoinNextRow()

The comment on the return-false path when both UNION siblings are
exhausted said "there are more rows," which is the opposite of what
the code does. The code itself is correct, returning false to signal
no more rows, but the misleading comment could tempt a reader into
"fixing" the return value, which would cause UNION plans to loop
indefinitely.

Back-patch to 17, where JSON_TABLE was introduced.

Author: Chuanwen Hu <463945512@qq.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/tencent_4CC6316F02DECA61ACCF22F933FEA5C12806@qq.com
Backpatch-through: 17
src/backend/utils/adt/jsonpath_exec.c