]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
smb: client: fix refcount leak in smb2_set_path_attr
authorShuhao Fu <sfual@cse.ust.hk>
Tue, 4 Nov 2025 15:13:15 +0000 (23:13 +0800)
committerSteve French <stfrench@microsoft.com>
Tue, 4 Nov 2025 22:03:56 +0000 (16:03 -0600)
commitb540de9e3b4fab3b9e10f30714a6f5c1b2a50ec3
tree59a6bd2a1c6b1b5d1d47bef5c55f0dfb993a2334
parent734e99623c5b65bf2c03e35978a0b980ebc3c2f8
smb: client: fix refcount leak in smb2_set_path_attr

Fix refcount leak in `smb2_set_path_attr` when path conversion fails.

Function `cifs_get_writable_path` returns `cfile` with its reference
counter `cfile->count` increased on success. Function `smb2_compound_op`
would decrease the reference counter for `cfile`, as stated in its
comment. By calling `smb2_rename_path`, the reference counter of `cfile`
would leak if `cifs_convert_path_to_utf16` fails in `smb2_set_path_attr`.

Fixes: 8de9e86c67ba ("cifs: create a helper to find a writeable handle by path name")
Acked-by: Henrique Carvalho <henrique.carvalho@suse.com>
Signed-off-by: Shuhao Fu <sfual@cse.ust.hk>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2inode.c