]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: cleaner_kthread() doesn't need explicit freeze
authorJiri Kosina <jkosina@suse.cz>
Tue, 15 Mar 2016 10:28:54 +0000 (11:28 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 May 2016 21:49:15 +0000 (14:49 -0700)
commitb54368c9a0b7124a0a1a0470a034442135ab8d35
treeb295271768ef433e72ddf51e6d6ae70e43e35b59
parent151d2afffebe6d5a5a34d50f8447e395bb8fd8a4
btrfs: cleaner_kthread() doesn't need explicit freeze

commit 838fe1887765f4cc679febea60d87d2a06bd300e upstream.

cleaner_kthread() is not marked freezable, and therefore calling
try_to_freeze() in its context is a pointless no-op.

In addition to that, as has been clearly demonstrated by 80ad623edd2d
("Revert "btrfs: clear PF_NOFREEZE in cleaner_kthread()"), it's perfectly
valid / legal for cleaner_kthread() to stay scheduled out in an arbitrary
place during suspend (in that particular example that was waiting for
reading of extent pages), so there is no need to leave any traces of
freezer in this kthread.

Fixes: 80ad623edd2d ("Revert "btrfs: clear PF_NOFREEZE in cleaner_kthread()")
Fixes: 696249132158 ("btrfs: clear PF_NOFREEZE in cleaner_kthread()")
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/disk-io.c