]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix problem with special case route targets ('remote_host')
authorGert Doering <gert@greenie.muc.de>
Thu, 21 Oct 2010 08:35:29 +0000 (10:35 +0200)
committerDavid Sommerseth <dazo@users.sourceforge.net>
Thu, 4 Nov 2010 19:29:53 +0000 (20:29 +0100)
commitb5da875c06d7ea028d32f369873eb700c82d93d4
tree7b42a8dc511b197694c4b3809d12a53c37b86c94
parent5f866d914c71f010988fd85d5b178f3b8c3e2987
Fix problem with special case route targets ('remote_host')

The init_route() function will leave &netlist untouched for
get_special_addr() routes ("remote_host" being one of them).
netlist is on stack,  contains random garbage, and netlist.len
will not be 0 - thus, random stack data is copied from
netlist.data[] until the route_list is full.

This issue has been reported several places lately:
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=600166
   http://thread.gmane.org/gmane.network.openvpn.devel/4083
   https://forums.openvpn.net/viewtopic.php?f=1&t=7201&p=8168

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: David Sommerseth <dazo@users.sourceforge.net>
Acked-by: James Yonan <james@openvpn.net>
Signed-off-by: David Sommerseth <dazo@users.sourceforge.net>
(cherry picked from commit 59afc4a5f72e22b850cfa2845385172623a38e77)
route.c