]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
tracing: Add down_write(trace_event_sem) when adding trace event
authorSteven Rostedt <rostedt@goodmis.org>
Sat, 19 Jul 2025 02:31:58 +0000 (22:31 -0400)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Sat, 19 Jul 2025 17:54:59 +0000 (13:54 -0400)
commitb5e8acc14dcb314a9b61ff19dcd9fdd0d88f70df
tree4a5abf90412f5544ab5ce4fa93c14ff51d688f14
parent85a3bce695b361d85fc528e6fbb33e4c8089c806
tracing: Add down_write(trace_event_sem) when adding trace event

When a module is loaded, it adds trace events defined by the module. It
may also need to modify the modules trace printk formats to replace enum
names with their values.

If two modules are loaded at the same time, the adding of the event to the
ftrace_events list can corrupt the walking of the list in the code that is
modifying the printk format strings and crash the kernel.

The addition of the event should take the trace_event_sem for write while
it adds the new event.

Also add a lockdep_assert_held() on that semaphore in
__trace_add_event_dirs() as it iterates the list.

Cc: stable@vger.kernel.org
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Link: https://lore.kernel.org/20250718223158.799bfc0c@batman.local.home
Reported-by: Fusheng Huang(黄富生) <Fusheng.Huang@luxshare-ict.com>
Closes: https://lore.kernel.org/all/20250717105007.46ccd18f@batman.local.home/
Fixes: 110bf2b764eb6 ("tracing: add protection around module events unload")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events.c