]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Commentary; run criteria.params() if statement isn't cached?
authorMike Bayer <mike_mp@zzzcomputing.com>
Sat, 27 Mar 2021 12:36:32 +0000 (08:36 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Sat, 27 Mar 2021 13:05:17 +0000 (09:05 -0400)
commitb619fbcbb277dd168c223be6b3ff960355f36b0c
treeacc677233b5275e05145a886ac61004612c5d56c
parent5e54c68fe5edec6f6c92153280799f2ad69aaff9
Commentary; run criteria.params() if statement isn't cached?

Considering adjustment to 56f9c7743e9083add69a10501a503f,
if statement is not cached, skip the relatively expensive
step of re-processing the criteria clause.

However, this causes the overall cache key of the statement
to come out differently which should also be avoided.

Likely we would not merge the actual change, just the
comment here.

References: #6139
Change-Id: Idb555b78d8d7950d084315e004448f64cf59bb5c
lib/sqlalchemy/orm/strategy_options.py
test/orm/test_relationship_criteria.py