]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: soc-pcm: don't use soc_pcm_ret() on .prepare callback
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 13 Dec 2024 01:21:10 +0000 (01:21 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Feb 2025 12:49:33 +0000 (13:49 +0100)
commitb65ba768302adc7ddc70811116cef80ca089af59
tree2809ff2d60beb46b1de0ad6f0c985815b8afaa19
parent4f8b210823cc2d1f9d967f089a6c00d025bb237f
ASoC: soc-pcm: don't use soc_pcm_ret() on .prepare callback

[ Upstream commit 301c26a018acb94dd537a4418cefa0f654500c6f ]

commit 1f5664351410 ("ASoC: lower "no backend DAIs enabled for ... Port"
log severity") ignores -EINVAL error message on common soc_pcm_ret().
It is used from many functions, ignoring -EINVAL is over-kill.

The reason why -EINVAL was ignored was it really should only be used
upon invalid parameters coming from userspace and in that case we don't
want to log an error since we do not want to give userspace a way to do
a denial-of-service attack on the syslog / diskspace.

So don't use soc_pcm_ret() on .prepare callback is better idea.

Link: https://lore.kernel.org/r/87v7vptzap.wl-kuninori.morimoto.gx@renesas.com
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://patch.msgid.link/87bjxg8jju.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/soc-pcm.c