]> git.ipfire.org Git - thirdparty/linux.git/commit
fs/buffer: add alert in try_to_free_buffers() for folios without buffers
authorDeepakkumar Karn <dkarn@redhat.com>
Thu, 11 Dec 2025 13:12:11 +0000 (18:42 +0530)
committerChristian Brauner <brauner@kernel.org>
Mon, 15 Dec 2025 14:07:22 +0000 (15:07 +0100)
commitb68f91ef3b3fe82ad78c417de71b675699a8467c
tree53b7ff46b8c071dd662c3c8c939ef9c7df7ca349
parent961b2ad1b4131c947cbc75700c83a6deb0c91d02
fs/buffer: add alert in try_to_free_buffers() for folios without buffers

try_to_free_buffers() can be called on folios with no buffers attached
when filemap_release_folio() is invoked on a folio belonging to a mapping
with AS_RELEASE_ALWAYS set but no release_folio operation defined.

In such cases, folio_needs_release() returns true because of the
AS_RELEASE_ALWAYS flag, but the folio has no private buffer data. This
causes try_to_free_buffers() to call drop_buffers() on a folio with no
buffers, leading to a null pointer dereference.

Adding a check in try_to_free_buffers() to return early if the folio has no
buffers attached, with WARN_ON_ONCE() to alert about the misconfiguration.
This provides defensive hardening.

Signed-off-by: Deepakkumar Karn <dkarn@redhat.com>
Link: https://patch.msgid.link/20251211131211.308021-1-dkarn@redhat.com
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/buffer.c