]> git.ipfire.org Git - thirdparty/linux.git/commit
staging: gpib: comment out pnp_device_id tables
authorArnd Bergmann <arnd@arndb.de>
Mon, 17 Feb 2025 13:13:36 +0000 (14:13 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Feb 2025 15:49:11 +0000 (16:49 +0100)
commitb6fe18d08d18943bdb139c4cf9a88e31a7f6959a
treeea5fea9ba40934563cd13bc73aa14b3d412984c3
parent18ea3495c54d291a566add350f1de8bfa3166517
staging: gpib: comment out pnp_device_id tables

This variable is not referenced in either of these two drivers driver,
causing a warning when they are built-in and W=1 warnings are enabled
with gcc:

drivers/staging/gpib/tnt4882/tnt4882_gpib.c:1507:35: error: 'tnt4882_pnp_table' defined but not used [-Werror=unused-const-variable=]
 1507 | static const struct pnp_device_id tnt4882_pnp_table[] = {
      |                                   ^~~~~~~~~~~~~~~~~
drivers/staging/gpib/hp_82341/hp_82341.c:811:35: error: 'hp_82341_pnp_table' defined but not used [-Werror=unused-const-variable=]
  811 | static const struct pnp_device_id hp_82341_pnp_table[] = {

The MODULE_DEVICE_TABLE() entry does have the effect of loading
the module when the PNP device is detected, so it is still needed
for the modular case.

Ideally the drivers should be converted to pnp_register_driver(),
which would lead to the ID table actually being used.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20250217131356.3759347-2-arnd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/hp_82341/hp_82341.c
drivers/staging/gpib/tnt4882/tnt4882_gpib.c