]> git.ipfire.org Git - thirdparty/curl.git/commit
windows: fix linking .rc to shared curl with autotools
authorViktor Szakats <commit@vsz.me>
Thu, 27 Oct 2022 06:45:32 +0000 (06:45 +0000)
committerViktor Szakats <commit@vsz.me>
Thu, 27 Oct 2022 06:45:32 +0000 (06:45 +0000)
commitb7260c4fda95196b2fa16f32b5913f25323e5098
treed494ad5ef4d49a9d150cee92241aeb9a0e31eb6a
parent811c799f2db1bbcf22e7ceee1e8c2c21525274de
windows: fix linking .rc to shared curl with autotools

`./configure --enable-shared --disable-static` fails when trying to link
a shared `curl.exe`, due to `libtool` magically changing the output
filename of `windres` to one that it doesn't find when linking:

```
/bin/sh ../libtool --tag=RC --mode=compile windres -I../../curl/include -DCURL_EMBED_MANIFEST  -i ../../curl/src/curl.rc -o curl.o
libtool: compile:  windres -I../../curl/include -DCURL_EMBED_MANIFEST -i ../../curl/src/curl.rc  -o .libs/curl.o
[...]
CCLD     curl.exe
clang: error: no such file or directory: 'curl.o'
```

Let's resolve this by skipping `libtool` and calling `windres` directly
when building `src` (aka `curl.exe`). Leave `lib` unchanged, as it does
need the `libtool` magic. This solution is compatible with building
a static `curl.exe`.

This build scenario is not CI-tested.

While here, delete an obsolete comment about a permanent `libtool`
warning that we've resolved earlier.

Regression from 6de7322c03d5b4d91576a7d9fc893e03cc9d1057

Reported-by: Christoph Reiter
Fixes #9803
Closes #9805
lib/Makefile.am
src/Makefile.am