]> git.ipfire.org Git - thirdparty/openvpn.git/commit
block-dns using iservice: fix a potential double free
authorSelva Nair <selva.nair@gmail.com>
Wed, 1 Feb 2023 17:07:35 +0000 (12:07 -0500)
committerGert Doering <gert@greenie.muc.de>
Thu, 2 Feb 2023 08:37:44 +0000 (09:37 +0100)
commitb761cb9bc942b6077f0b6e2b85a72e33fc618a0f
treec0609942cd693b4e8bcc07db9e0a1a5c900f57e8
parentb2e49465e6b837d97ecb3a4edbc06aba00584381
block-dns using iservice: fix a potential double free

- An item added to undo-list was not removed on error, causing
  attempt to free again in Undo().
  Also fix a memory leak possibility in the same context.

Github: fixes OpenVPN/openvpn#232

v2: Split add and delete functions and reuse the delete
function for cleanup.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Lev Stipakov <lstipakov@gmail.com>
Message-Id: <20230201170735.2266851-1-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26130.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpnserv/interactive.c