]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MEDIUM: logs: fix improper systematic use of quotes with a few tags
authorWilly Tarreau <w@1wt.eu>
Wed, 17 Jun 2015 17:58:02 +0000 (19:58 +0200)
committerWilly Tarreau <w@1wt.eu>
Wed, 17 Jun 2015 17:58:02 +0000 (19:58 +0200)
commitb7636d1a100419b3e88f7de4b2eea32f8351eb73
tree136a8dbe3cb890f5a4918af3f19965d53c9d3924
parent7810ad7d597a801b520cd12b182ad67e14388d31
BUG/MEDIUM: logs: fix improper systematic use of quotes with a few tags

Dmitry Sivachenko reported the following build warning using Clang, which
is a real bug :

  src/log.c:1538:22: warning: use of logical '&&' with constant operand
        [-Wconstant-logical-operand]
                                  if (tmp->options && LOG_OPT_QUOTE)
                                                   ^  ~~~~~~~~~~~~~
The effect is that recent log tags related to HTTP method, path, uri,
query have a bug making them always use quotes.

This bug was introduced in 1.6-dev2 with commit 0ebc55f ("MEDIUM: logs:
Add HTTP request-line log format directives"), so no backport is needed.
src/log.c