]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
iio: gyro: itg3200: Fix unchecked return value in read_raw
authorAntoniu Miclaus <antoniu.miclaus@analog.com>
Thu, 29 Jan 2026 15:01:45 +0000 (17:01 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 29 Jan 2026 17:07:07 +0000 (17:07 +0000)
commitb79b24f578cdb2d657db23e5fafe82c7e6a36b72
tree055aab6dd4225d9bae980ba038c922350ec5a891
parent53f0a73f9ec7575d4e59dc8dc70e891979ee2014
iio: gyro: itg3200: Fix unchecked return value in read_raw

The return value from itg3200_read_reg_s16() is stored in ret but
never checked. The function unconditionally returns IIO_VAL_INT,
ignoring potential I2C read failures. This causes garbage data to
be returned to userspace when the read fails, with no error reported.

Add proper error checking to propagate the failure to callers.

Fixes: 9dbf091da080 ("iio: gyro: Add itg3200")
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/gyro/itg3200_core.c