]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
block: blkdev_get() should access ->bd_disk only after success
authorTejun Heo <tj@kernel.org>
Wed, 1 Jun 2011 06:27:41 +0000 (08:27 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 23 Jun 2011 22:05:32 +0000 (15:05 -0700)
commitb7f788ce3f4ad895fe29cb225765c54f59a64d4d
tree06b8a704aa550d2ed88c5ed43e54da1589d2ab39
parent344bfe4456acedc5087677dd84b5a1aaa3137f8b
block: blkdev_get() should access ->bd_disk only after success

commit 4c49ff3fe128ca68dabd07537415c419ad7f82f9 upstream.

d4dc210f69 (block: don't block events on excl write for non-optical
devices) added dereferencing of bdev->bd_disk to test
GENHD_FL_BLOCK_EVENTS_ON_EXCL_WRITE; however, bdev->bd_disk can be
%NULL if open failed which can lead to an oops.

Test the flag after testing open was successful, not before.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: David Miller <davem@davemloft.net>
Tested-by: David Miller <davem@davemloft.net>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/block_dev.c