]> git.ipfire.org Git - thirdparty/linux.git/commit
iommufd/selftest: Do not leak the hwpt if IOMMU_TEST_OP_MD_CHECK_MAP fails
authorJason Gunthorpe <jgg@nvidia.com>
Fri, 5 Dec 2025 19:42:47 +0000 (15:42 -0400)
committerJason Gunthorpe <jgg@nvidia.com>
Tue, 16 Dec 2025 00:34:41 +0000 (20:34 -0400)
commitb80fab281349f107a07e841eb412a86e2877ae88
treeb67131839357bff13c6c63f58ce489272ff0a95d
parent5b244b077c0b0e76573fbb9542cf038e42368901
iommufd/selftest: Do not leak the hwpt if IOMMU_TEST_OP_MD_CHECK_MAP fails

If the input validation fails it returned without freeing the hwpt
refcount causing a leak. This triggers a WARN_ON when closing the fd:

  WARNING: drivers/iommu/iommufd/main.c:369 at iommufd_fops_release+0x385/0x430, CPU#1: repro/724

Found by szykaller.

Fixes: e93d5945ed5b ("iommufd: Change the selftest to use iommupt instead of xarray")
Link: https://patch.msgid.link/r/0-v1-c8ed57e24380+44ae-iommufd_selftest_hwpt_leak_jgg@nvidia.com
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Reported-by: "Lai, Yi" <yi1.lai@linux.intel.com>
Closes: https://lore.kernel.org/r/aTJGMaqwQK0ASj0G@ly-workstation
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/iommu/iommufd/selftest.c