]> git.ipfire.org Git - thirdparty/linux.git/commit
firmware_loader: Replace simple_strtol() with kstrtoint()
authorKaushlendra Kumar <kaushlendra.kumar@intel.com>
Thu, 25 Sep 2025 06:38:12 +0000 (12:08 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Oct 2025 06:09:25 +0000 (08:09 +0200)
commitb811e8a01d8db2ea605e6158063aac0bf00c77b8
tree0e12dbf72ea8a77cceb24d8f16a5fbb38878f71a
parentfe6193a3187a1a7482ccfbc904bc527e7730a36c
firmware_loader: Replace simple_strtol() with kstrtoint()

Replace deprecated simple_strtol() calls with kstrtoint() in
timeout_store() and firmware_loading_store() functions to
improve input validation and error handling. The simple_strtol()
function does not provide proper error checking for invalid input,
while kstrtoint() returns an error for malformed strings.

This change adds proper validation for user input from sysfs attributes,
returning -EINVAL for invalid numeric strings instead of silently accepting
potentially malformed input. The behavior for valid numeric input remains
unchanged.

The simple_strtol() function is deprecated in favor of kstrtoint() family
functions which provide better error handling and are recommended for new
code and replacements.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Link: https://patch.msgid.link/20250925063812.2269501-1-kaushlendra.kumar@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_loader/sysfs.c