]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
idpf: trigger SW interrupt when exiting wb_on_itr mode
authorJoshua Hay <joshua.a.hay@intel.com>
Mon, 15 Dec 2025 21:42:41 +0000 (13:42 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:15:02 +0000 (10:15 +0100)
commitb82cc442aa533fc594c1a076653182f606099d12
treeffdc08145d74f6f79782f343eb441d95faea71b3
parentf2a43c70e517ed8ba8bbd487c06213e6a7144523
idpf: trigger SW interrupt when exiting wb_on_itr mode

[ Upstream commit 0c1683c681681c14f4389e3bfa8de10baf242ba8 ]

There is a race condition between exiting wb_on_itr and completion write
backs. For example, we are in wb_on_itr mode and a Tx completion is
generated by HW, ready to be written back, as we are re-enabling
interrupts:

HW                      SW
|                       |
| | idpf_tx_splitq_clean_all
|                       | napi_complete_done
| |
| tx_completion_wb  | idpf_vport_intr_update_itr_ena_irq

That tx_completion_wb happens before the vector is fully re-enabled.
Continuing with this example, it is a UDP stream and the
tx_completion_wb is the last one in the flow (there are no rx packets).
Because the HW generated the completion before the interrupt is fully
enabled, the HW will not fire the interrupt once the timer expires and
the write back will not happen. NAPI poll won't be called.  We have
indicated we're back in interrupt mode but nothing else will trigger the
interrupt. Therefore, the completion goes unprocessed, triggering a Tx
timeout.

To mitigate this, fire a SW triggered interrupt upon exiting wb_on_itr.
This interrupt will catch the rogue completion and avoid the timeout.
Add logic to set the appropriate bits in the vector's dyn_ctl register.

Fixes: 9c4a27da0ecc ("idpf: enable WB_ON_ITR")
Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
Signed-off-by: Joshua Hay <joshua.a.hay@intel.com>
Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/intel/idpf/idpf_txrx.c