]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging: comedi: comedi_compat32.c: fix COMEDI_CMD copy back
authorIan Abbott <abbotti@mev.co.uk>
Tue, 27 Jan 2015 18:16:51 +0000 (18:16 +0000)
committerJiri Slaby <jslaby@suse.cz>
Mon, 16 Mar 2015 13:58:16 +0000 (14:58 +0100)
commitb848046a02bc2a35da3f6a0fbae8db6ff1691cc4
tree85ac4137589e5408281f7fdf8d2464226547be06
parent23b96e928e19077011c4c96719ea708dcb8c3953
staging: comedi: comedi_compat32.c: fix COMEDI_CMD copy back

commit 42b8ce6f55facfa101462e694d33fc6bca471138 upstream.

`do_cmd_ioctl()` in "comedi_fops.c" handles the `COMEDI_CMD` ioctl.
This returns `-EAGAIN` if it has copied a modified `struct comedi_cmd`
back to user-space.  (This occurs when the low-level Comedi driver's
`do_cmdtest()` handler returns non-zero to indicate a problem with the
contents of the `struct comedi_cmd`, or when the `struct comedi_cmd` has
the `CMDF_BOGUS` flag set.)

`compat_cmd()` in "comedi_compat32.c" handles the 32-bit compatible
version of the `COMEDI_CMD` ioctl.  Currently, it never copies a 32-bit
compatible version of `struct comedi_cmd` back to user-space, which is
at odds with the way the regular `COMEDI_CMD` ioctl is handled.  To fix
it, change `compat_cmd()` to copy a 32-bit compatible version of the
`struct comedi_cmd` back to user-space when the main ioctl handler
returns `-EAGAIN`.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/staging/comedi/comedi_compat32.c